feat: add attributes conditional attribute to add support for removing runtime assets #1027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1027 +/- ##
==========================================
- Coverage 91.37% 91.30% -0.07%
==========================================
Files 223 220 -3
Lines 7231 7168 -63
Branches 914 911 -3
==========================================
- Hits 6607 6545 -62
Misses 412 412
+ Partials 212 211 -1 ☔ View full report in Codecov by Sentry. |
ni507
approved these changes
Dec 21, 2023
|
🎉 This PR is included in version 3.4.0-next.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.4.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add conditional attributes
Description
This adds the conditional attribute to the attributes and allows the removal of the runtime assets of Mapperly (
ExcludeAssets="runtime"), except when using reference handling. Removes the templates since they are not needed anymore. The constantMAPPERLY_ABSTRACTIONS_SCOPE_RUNTIMEallows to keep the attributes at runtime.Fixes #881
Fixes #1015
Fixes #849