Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V4 - QCS configuration should fallback on defaults for omitted fields. #1604

Closed
MarquessV opened this issue Jun 29, 2023 · 1 comment
Closed

V4 - QCS configuration should fallback on defaults for omitted fields. #1604

MarquessV opened this issue Jun 29, 2023 · 1 comment
Labels
bug 🐛 An issue that needs fixing. v4
Milestone
v4.0

Comments

@MarquessV
Copy link
Contributor

In v3, a settings.toml file could be loaded that didn't necessarily have every configuration field defined. In this case, the client would get reasonable defaults for those fields. In v4, if the user has a config like this, some fields don't fallback on a default, which can lead to errors that otherwise wouldn't occur.
@MarquessV MarquessV added the bug 🐛 An issue that needs fixing. label Jun 29, 2023
@MarquessV MarquessV added this to the v4.0 milestone Jun 29, 2023
@MarquessV MarquessV added the v4 label Jun 29, 2023
@MarquessV MarquessV mentioned this issue Jun 29, 2023
Merged
@MarquessV
Copy link
Contributor Author

closed by #1605

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 An issue that needs fixing. v4
Projects
None yet
Milestone
v4.0
Development

No branches or pull requests
1 participant
@MarquessV