From 8154b9f1dba236b1c939eaa8782c41440ab1804a Mon Sep 17 00:00:00 2001 From: Philippe Rigaux Date: Thu, 24 Oct 2024 14:12:51 +0200 Subject: [PATCH 1/4] Correction edition keysign --- lib/collabscore/parser.py | 3 +- rest/json_examples/replace_keysign.json | 5 +- rest/json_examples/t.xml | 71 +++++++++++++------------ 3 files changed, 42 insertions(+), 37 deletions(-) diff --git a/lib/collabscore/parser.py b/lib/collabscore/parser.py index 650349f..13f15db 100644 --- a/lib/collabscore/parser.py +++ b/lib/collabscore/parser.py @@ -847,6 +847,7 @@ def write_as_musicxml(self, out_file): print ("\n\nApplying post-editions to the MusicXML file\n") Edition.apply_editions_to_file (self.post_editions, out_file) + print ("\nPost-editions done\n") def write_as_mei(self, mxml_file, out_file): @@ -1225,7 +1226,7 @@ def overwrite (self, replacement): elif nb_sharps > 0: self.element = SHARP_SYMBOL self.nb_alterations = nb_sharps - elif nb_sharps > 0: + elif nb_flats > 0: self.element = FLAT_SYMBOL self.nb_alterations = nb_flats diff --git a/rest/json_examples/replace_keysign.json b/rest/json_examples/replace_keysign.json index a9c6bc6..79d7654 100644 --- a/rest/json_examples/replace_keysign.json +++ b/rest/json_examples/replace_keysign.json @@ -2,10 +2,9 @@ { "name": "replace_keysign", "params": { - "id": "ks_1307_1721", + "id": "ks_1323_1721", "values": { - "nb_sharps": 2, - "nb_flats": 0 + "nb_sharps": 5 } } } diff --git a/rest/json_examples/t.xml b/rest/json_examples/t.xml index e3a7cd6..6155bf7 100644 --- a/rest/json_examples/t.xml +++ b/rest/json_examples/t.xml @@ -7,7 +7,7 @@ CollabScore project - 2024-10-23 + 2024-10-24 music21 v.9.1.0 DMOS/Collabscore OMR @@ -19,27 +19,27 @@ - + Part2 Part2 - + Part1 Part1 - + 10080 - - -2 + + 5 - - + 10080 - + -2