Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

riemann-dash 0.1.1 gem: start_chart: no method nan? for fixnum #2

Closed
ianrumford opened this issue Dec 19, 2012 · 4 comments
Closed

Comments

@ianrumford
Copy link

Using the 0.1.1 riemann-dash gem

riemann/dash/helper/renderer.rb method state_chart has the following line:

if s.metric && !(s.metric.nan?)

I do not understand why but this can generate a no method exception nan? for fixnum.

A simple workaround is e.g.

if s.metric && !(s.metric.nan? rescue true)

but this just conceals the underlying problem.

@aphyr
Copy link
Collaborator

aphyr commented Dec 19, 2012

Fixnums couldn't appear there until recently. The newest version of riemann-ruby-client added support. I'm pretty close to obsoleting that whole ruby dash in favor of the realtime js dashboard; you might give /ws a try.

ianrumford notifications@github.com wrote:

Using the 0.1.1 riemann-dash gem

riemann/dash/helper/renderer.rb method state_chart has the following line:

if s.metric && !(s.metric.nan?)

I do not understand why but this can generate a no method exception nan? for fixnum.

A simple workaround is e.g.

if s.metric && !(s.metric.nan? rescue true)

but this just conceals the underlying problem.


Reply to this email directly or view it on GitHub.

@ianrumford
Copy link
Author

Would be interested to see / try the realtime dash when your're ready. Realtime is where I want to be eventually.

@aphyr
Copy link
Collaborator

aphyr commented Dec 19, 2012

Check out master from riemann-dash and go to localhost:4567/ws :)

ianrumford notifications@github.com wrote:

Would be interested to see / try the realtime dash when your're ready. Realtime is where I want to be eventually.


Reply to this email directly or view it on GitHub.

@aphyr
Copy link
Collaborator

aphyr commented Jan 25, 2013

Closing with the move to the new dash

@aphyr aphyr closed this as completed Jan 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants