Skip to content
This repository has been archived by the owner on Jul 27, 2023. It is now read-only.

Support for multiple tags #157

Closed
rraziel opened this issue Sep 2, 2016 · 6 comments
Closed

Support for multiple tags #157

rraziel opened this issue Sep 2, 2016 · 6 comments

Comments

@rraziel
Copy link

rraziel commented Sep 2, 2016

Hello,

Right now with a CatalogOptions we can only specify one tag (which is what the Consul API offered anyway, so it made sense), however it is now possible to query for multiple tags at the same time, and some clients for other languages have started implementing it.

For now it can only be done using prepared statements:

Any chance this could be added to your library?

Thanks.

@rickfast
Copy link
Owner

rickfast commented Sep 8, 2016

It can be added, but I'm on vacation for the next week and won't get to it any time soon. It should be a relatively trivial change if you'd like to make a pull request.

@rickfast
Copy link
Owner

Waiting on square/retrofit#1324 to fix this

@shaharck
Copy link
Contributor

FYI this is needed from the newly introduced node-meta filter as well

@rickfast
Copy link
Owner

I have a release candidate out with this change: 0.14.0-RC1. Try it out

@shaharck
Copy link
Contributor

shaharck commented Feb 18, 2017

@rickfast that was super fast :) works great

@thomas-oo
Copy link

Sorry this is a bit confusing, I'm using 0.15.0 and it's claimed to be fixed in 0.14.0. Multiple tag queries in CatalogClient.getServices(service, queryOptions) for example doesn't work and only filters using the first tag. There's an upstream issue in consul where multiple tags have not been supported through the parameters.

On a sidenote: Could you explain where the fix you observed was? I'd love multi tag support.

Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants