Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSL support #27

Open
jcohen02 opened this issue Feb 25, 2019 · 2 comments
Open

SSL support #27

jcohen02 opened this issue Feb 25, 2019 · 2 comments

Comments

@jcohen02
Copy link

Hi,
With the recent merging of SSL support into master in hiredis (redis/hiredis#645), it would be great to have the ability to make secure connections to redis via redux.

An initial implementation of this is available in jcohen02/redux@1c0232b but I wanted to get thoughts on this prior to submitting a PR - I'm assuming this will require a modified version of hiredis to be made available in rwinlib/hiredis but I wasn't clear at this stage whether it might present other cross-platform/dependency issues.

@EnvisionRisk
Copy link

Hi @richfitz,
Is SSL support a feature that will be available in the redux package?
Best wishes
Jonas

@jcohen02
Copy link
Author

@richfitz, @jeroen the feature/ssl branch in my fork has now been updated to use the modified API in hiredis 1.0.0.

I've updated tools/winlibs.R to pull hiredis-1.0.0 from rwinlib/hiredis and updated Makevars.win to add the necessary libraries for building with SSL support.

I had some issues on Mac OS since I was building using my own build of hiredis-1.0.0 and avoiding the brew-based scripts, this may need some further checking along with Linux builds.

Should we be looking to build with SSL support by default or is there some way to pass an option via install.packages or similar to specify whether or not to install redux with SSL support - is this necessary.

Once I've completed some further testing, I'll open a PR in preparation for getting this merged into the main repo.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants