Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hard tab now adds extra padding character on display #43

Closed
pm100 opened this issue Nov 3, 2023 · 4 comments
Closed

hard tab now adds extra padding character on display #43

pm100 opened this issue Nov 3, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@pm100
Copy link
Contributor

pm100 commented Nov 3, 2023

on current head

run minimal sample with hard tab set on (I set width to 10),

enter a\tb\na\b

display is

image

now cursor left into the gap

image

the tab space grew by one character

I have tried an initial debug but its not obvious
@rhysd
Copy link
Owner

rhysd commented Nov 4, 2023 •
edited
Loading

Thank you for reporting. This is a bug. I could reproduce it. I'll take a look.

@rhysd rhysd added the bug Something isn't working label Nov 4, 2023
@pm100
Copy link
Contributor Author

pm100 commented Nov 4, 2023

Did you see my question about hard tabs ? In the insert_str closed issue

@rhysd
Copy link
Owner

rhysd commented Nov 4, 2023

@pm100 I haven't seen it. I'll check.

I confirmed the root cause of this issue and now fixing it with refactoring highlight.rs.

@rhysd rhysd closed this as completed in 4d16fcb Nov 4, 2023
@rhysd
Copy link
Owner

rhysd commented Nov 4, 2023

I confirmed the fix:

tmp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pm100 @rhysd