Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credentials in the changelog #9

Closed
maxim-smirnov opened this issue May 11, 2022 · 6 comments
Closed

Credentials in the changelog #9

maxim-smirnov opened this issue May 11, 2022 · 6 comments

Comments

@maxim-smirnov
Copy link

I think it would be great to strip credentials provided in .git/config

Here is the result if you're using GitHub personal tokens.

<a name="v1.0.10"></a>
 # [v1.0.10](https://maxim-smirnov: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@github.com/maxim-smirnov/homebridge-neptun-smart/releases/tag/v1.0.10) - 11 May 2022

 **fix:** Now using unique name for valves of the second group

 **Full Changelog**: https://github.com/maxim-smirnov/homebridge-neptun-smart/compare/v1.0.9...v1.0.10

 [Changes][v1.0.10]
@rhysd
Copy link
Owner

rhysd commented May 12, 2022

Is https://github.com/maxim-smirnov/homebridge-neptun-smart/releases/tag/v1.0.10 the URL you expected?

@maxim-smirnov
Copy link
Author

The result link represents the commit, where I’ve committed my token :)

And the code block just shows the beginning of CHANGELOG.md.

@rhysd rhysd closed this as completed in ef2a40c May 12, 2022
@rhysd
Copy link
Owner

rhysd commented May 12, 2022

@maxim-smirnov I added fix for this issue at ef2a40c. Can you confirm the fix?

cd /path/to/your/repository
go install github.com/rhysd/changelog-from-release
changelog-from-release

@maxim-smirnov
Copy link
Author

I've checked the commit. Seems like it's fixed!
Can you please provide new release with the binary? Thanks!

@rhysd
Copy link
Owner

rhysd commented May 12, 2022

Yes, I'll make a new release once other fixes are confirmed.

@rhysd
Copy link
Owner

rhysd commented May 12, 2022

v2.2.4 was released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants