Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose Prometheus ExternalLabels in MSO #125

Closed
cmwylie19 opened this issue Apr 29, 2022 · 1 comment
Closed

Expose Prometheus ExternalLabels in MSO #125

cmwylie19 opened this issue Apr 29, 2022 · 1 comment

Comments

@cmwylie19
Copy link
Contributor

Prometheus has the notion of ExternalLabels to label and identify outgoing metrics to a RemoteWrite endpoint.

The MSO should expose these options in the CRD, then copy them to the Prometheus CRD.

We need to leverage Prometheus External Labels to add information related to the client and cluster to the prometheus metrics to easily distinguish which customer is having problems and from which clusters.
@cmwylie19
Copy link
Contributor Author

Addressed in PR #126

@cmwylie19 cmwylie19 mentioned this issue Apr 29, 2022
Merged
@sthaha sthaha closed this as completed in 02289d1 May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cmwylie19