Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump Prometheus operator to v0.74.0 #518

Merged

Conversation

marioferh
Copy link
Contributor

No description provided.

@marioferh marioferh requested a review from a team as a code owner June 14, 2024 08:34
@marioferh marioferh requested review from danielmellado and slashpai and removed request for a team June 14, 2024 08:34
@marioferh marioferh force-pushed the bump_obo-prometheus-operator_0.74.0 branch from e5b95ea to f9c7fe0 Compare June 14, 2024 08:37
Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Jun 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marioferh, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [marioferh,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label Jun 14, 2024
@marioferh marioferh force-pushed the bump_obo-prometheus-operator_0.74.0 branch from 0d56b6f to 4fbf72e Compare June 14, 2024 12:54
Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 14, 2024
@simonpasquier
Copy link
Contributor

/hold
shellcheck is blocking

@marioferh
Copy link
Contributor Author

/hold shellcheck is blocking

is no shellheck, is this test after the enableGate type change:

    +++ expected
      map[string]any{
      	... // 2 identical entries
      	"f:alerting":                    map[string]any{"f:alertmanagers": map[string]any{}},
      	"f:arbitraryFSAccessThroughSMs": map[string]any{},
    - 	"f:enableFeatures":              map[string]any{`v:"otlp-write-receiver"`: map[string]any{}},
    + 	"f:enableFeatures":              map[string]any{},
      	"f:enableRemoteWriteReceiver":   map[string]any{},
      	"f:externalLabels":              map[string]any{"f:key": map[string]any{}},
      	... // 24 identical entries
      }

let me fix it

@marioferh marioferh force-pushed the bump_obo-prometheus-operator_0.74.0 branch from 4fbf72e to 897485a Compare June 14, 2024 13:08
@openshift-ci openshift-ci bot removed the lgtm label Jun 14, 2024
@marioferh
Copy link
Contributor Author

marioferh commented Jun 14, 2024

> "f:enableFeatures": map[string]any{v:"otlp-write-receiver": map[string]any{}},

in fact before the expected was:
"f:enableFeatures": map[string]any{},
and the test passed... should be:

"f:enableFeatures": map[string]any{v:"otlp-write-receiver": map[string]any{}},

as right now..

if:
EnableOtlpHttpReceiver: func(b bool) *bool { return &b }(true),

then:

there was a bug before?

@marioferh marioferh force-pushed the bump_obo-prometheus-operator_0.74.0 branch 5 times, most recently from b8b42dc to 364eaaf Compare June 14, 2024 16:44
@rhobs rhobs deleted a comment from openshift-ci bot Jun 14, 2024
Signed-off-by: Mario Fernandez <mariofer@redhat.com>
@marioferh marioferh force-pushed the bump_obo-prometheus-operator_0.74.0 branch from 364eaaf to 1c6fbf9 Compare June 14, 2024 17:02
@simonpasquier
Copy link
Contributor

there was a bug before?

no bug but an upstream change that broke the test :)

prometheus-operator/prometheus-operator@3e0d0f86f2

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 17, 2024
@marioferh
Copy link
Contributor Author

/unhold

@openshift-merge-bot openshift-merge-bot bot merged commit abd2f03 into rhobs:main Jun 17, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants