Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COO-183: Prevent Reconcile Loop for Troubleshooting Panel UIPlugin #505

Conversation

PeterYurkovich
Copy link
Contributor

@PeterYurkovich PeterYurkovich commented Jun 7, 2024

Although the troubleshooting panel will deploy after #501, it reconciles in a loop.

Since the UIPlugin proxy spec is still of type v1alpha1, when it is created it gets converted to use v1 instead. Having authorize: false creates a v1 version that is different enough from from the v1alpha1 to cause a reconciliation. However, the conversion again happens leading to a loop.

@PeterYurkovich PeterYurkovich requested a review from a team as a code owner June 7, 2024 18:40
@PeterYurkovich PeterYurkovich requested review from simonpasquier and sthaha and removed request for a team June 7, 2024 18:40
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jun 7, 2024

@PeterYurkovich: This pull request references COO-183 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to this:

Although the troubleshooting panel with deploy after #501, it reconciles in a loop.

Since the UIPlugin proxy spec is still of type v1alpha1, when it is created it gets converted to use v1 instead. Having authorize: false creates a v1 version that is different enough from from the v1alpha1 to cause a reconciliation. However, the conversion again happens leading to a loop.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented Jun 7, 2024

Hi @PeterYurkovich. Thanks for your PR.

I'm waiting for a rhobs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jun 7, 2024

@PeterYurkovich: This pull request references COO-183 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to this:

Although the troubleshooting panel will deploy after #501, it reconciles in a loop.

Since the UIPlugin proxy spec is still of type v1alpha1, when it is created it gets converted to use v1 instead. Having authorize: false creates a v1 version that is different enough from from the v1alpha1 to cause a reconciliation. However, the conversion again happens leading to a loop.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jgbernalp
Copy link
Contributor

/approve
/lgtm

@simonpasquier
Copy link
Contributor

/approve

Copy link

openshift-ci bot commented Jun 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgbernalp, PeterYurkovich, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@simonpasquier
Copy link
Contributor

/ok-to-test

@openshift-merge-bot openshift-merge-bot bot merged commit 994ad0b into rhobs:main Jun 10, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants