Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COO-179: fix: compatibility matrix version validation #501

Merged
merged 1 commit into from
Jun 7, 2024
Merged

COO-179: fix: compatibility matrix version validation #501

merged 1 commit into from
Jun 7, 2024

Conversation

jgbernalp
Copy link
Contributor

@jgbernalp jgbernalp commented Jun 6, 2024 •
edited by openshift-ci bot
Loading

This PR fixes the min version semver validation for allowing plugins to be enabled in nightly cluster versions.

COO-179

@jgbernalp jgbernalp requested a review from a team as a code owner June 6, 2024 18:01
@jgbernalp jgbernalp requested review from danielmellado and JoaoBraveCoding and removed request for a team June 6, 2024 18:01
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jun 6, 2024 •
edited by openshift-ci bot
Loading

@jgbernalp: This pull request references COO-179 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to this:

This PR fixes the min version semver validation for allowing plugins to be enabled in nightly cluster versions.

COO-179

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from jan--f and tremes June 6, 2024 18:01
@jgbernalp
Copy link
Contributor Author

/test images

@jgbernalp
Copy link
Contributor Author

/retest

@simonpasquier
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 7, 2024
@simonpasquier
Copy link
Contributor

/approve

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgbernalp, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jun 7, 2024
@jgbernalp
Copy link
Contributor Author

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit facefdc into rhobs:main Jun 7, 2024
11 checks passed
@PeterYurkovich PeterYurkovich mentioned this pull request Jun 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielmellado danielmellado Awaiting requested review from danielmellado danielmellado is a code owner automatically assigned from rhobs/observability-operator-maintainers

@JoaoBraveCoding JoaoBraveCoding Awaiting requested review from JoaoBraveCoding JoaoBraveCoding is a code owner automatically assigned from rhobs/observability-operator-maintainers

@jan--f jan--f Awaiting requested review from jan--f

@tremes tremes Awaiting requested review from tremes

Assignees

@simonpasquier simonpasquier

Labels
approved jira/valid-reference lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jgbernalp @openshift-ci-robot @simonpasquier