Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latent Variable Support for Analysis Summed #1085

Open
Jammy2211 opened this issue Dec 19, 2024 · 1 comment
Open

Latent Variable Support for Analysis Summed #1085

Jammy2211 opened this issue Dec 19, 2024 · 1 comment
Assignees

Comments

@Jammy2211
Copy link
Collaborator

The following PR implements a hotfix to get latent variables working for summed Analysis objects:

#1084

We need to flesh out the PR so that latent variables fully use all summed Analysis features, for example when the model has free parameters that vary across the analysis objects.

However, it may just be that no source code changes are required and its up to a user to customize their compute_latent_variables correctly.

We can discuss this in the new year.

@rhayes777
Copy link
Owner

I suppose it's possible that each of the analyses that have been combined may have its own latent variables and so we need to compute latent variables for each separate analysis? Perhaps we need to call this for each analysis with a distinct type.

The same could arguably apply to visualisation. At the moment we're favouring the first analysis. The avoids repetition where all analyses are the same but if a user is composing multiple distinct analyses they will be missing visualisation.

I find these combined analyses hard to reason about - sometimes I wonder if we've got the abstraction right!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants