Multistep targeting creates some selector problems

[rhardih]

Disregards the data-tags in the markup below, they're only there to tell tags apart. Consider the following:

<div>
  <div></div>
  <p data-first></p>
  <p data-second></p>
</div>

Killing the first p element here would result in a stored selector of div > p:nth-of-type(1), which is correct in that it uniquely targets that element.

Reloading the page will let ekill remove that p element so the markup now looks like this:

<div>
  <div></div>
  <p data-second></p>
</div>

What happens when the second p element is now killed?

Two things go wrong here. Firstly the generated DOMString will be just be div > p, since that is correct for this new markup, and secondly it will remove the previously stored div > p:nth-of-type(1), because the substring match will consider div > p to signify a parent of div > p:nth-of-type(1).

In the end, what is left in the Hit List is just div > p, which is obviously wrong with regards to what the user intended, which was to have both elements killed off.

[rhardih]

Second issue here is fixed by 8654d22.

[rhardih]

One possible solution would be to just inject style.display = 'none', instead of actually removing the element from the dom.