Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HEAD_REF pointing to wrong ref #125

Closed
lmslopes opened this issue Sep 25, 2024 · 3 comments
Closed

HEAD_REF pointing to wrong ref #125

lmslopes opened this issue Sep 25, 2024 · 3 comments

Comments

@lmslopes
Copy link

Hi, in action.yml file I think you are wrongly defining the HEAD_REF,

HEAD_REF: ${{ github.sha }}

It should be pointing to HEAD_sha

#action.yml ... BASE_REF: ${{ github.event.pull_request.base.sha }} HEAD_REF: ${{ github.event.pull_request.head.sha }}

@ch-minhvu
Copy link

Not sure anyone raised this but this PR caused the issue #103

@ch-minhvu
Copy link

@toy hi please help to review this issue

@toy
Copy link
Contributor

toy commented Dec 16, 2024

The question about using github.sha and not github.event.pull_request.head.sha was already asked in the PR, see my reasoning in the comment https://github.com/reviewdog/action-rubocop/pull/103/files#r1654666250

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants