Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: OpenGL - Full screen windows #58

Open
bryphe opened this issue Dec 18, 2018 · 0 comments
Open

API: OpenGL - Full screen windows #58

bryphe opened this issue Dec 18, 2018 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@bryphe
Copy link
Member

bryphe commented Dec 18, 2018

Currently, we only support 'maximized' windows. However, it's desirable to have a full-screen experience.

In GLFW, this is described in the window guide and can be set with the glfwSetWindowMonitor API. Fullscreen mode can be unset with this same API.

On the web, we can use Element.requestFulllscreen and Document.exitFullScreen to enter / exit fullscreen mode. https://developer.mozilla.org/en-US/docs/Web/API/Fullscreen_API.

My proposal is to implement the glfwSetWindowMonitor API, and use the Element.requestFullScreen/Document.exitFullscreen depending on whether the monitor parameter is set/unset.

To test this - we can add a key handler for f key, which toggles fullscreen mode in the sample app.

@bryphe bryphe added enhancement New feature or request help wanted Extra attention is needed labels Dec 18, 2018
@bryphe bryphe changed the title API: Full screen windows API: OpenGL - Full screen windows Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant