Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go to production #13

Open
Ryszard-Trojnacki opened this issue Oct 5, 2024 · 7 comments
Open

Go to production #13

Ryszard-Trojnacki opened this issue Oct 5, 2024 · 7 comments

Comments

@Ryszard-Trojnacki
Copy link

Hi,

I'm using this library in few my projects for some time (over 3 months) and everythings works fine.
Maybe it is time to go from testing/dev to production?

By production I mean:

  • change package name from dev to org.jboss,
  • add this library into maven repository; so far I have build step in my projects, to download it from repository and build.
@iain-davis
Copy link
Contributor

@Ryszard-Trojnacki You've answered one of the questions on my mind, I had been wondering if anyone was using the library in their projects. Any issues come up getting it added to your projects?

I'd like to see a published jar as well.

Also, it might be nice to see if we can get it working with Jitpack. I attempted to use Jitpack to pull it into an experimental project yesterday and Jitpack had problems building it; I ran out of time before I identified what the issue was. :)

@Ryszard-Trojnacki
Copy link
Author

Any issues come up getting it added to your projects?

I'm using RESTEasy Guice for a long time - for few years in several projects. Before I had to stay with RESTEasy 4.7.9.
Few months ago, when you published this new version of RESTEasy, I migrated two of my projects and so far everything works fine. I didn't experience any problems and everything works like it should be, like it worked in old RESTEasy.

But two things:

  • I don't use @RequestScoped,
  • I configure this by code in Jetty:
                var restEasy = injector.getInstance(GuiceResteasyBootstrapServletContextListener.class);
                main.addEventListener(restEasy);
                main.setInitParameter("resteasy.guice.modules", RestModule.class.getName());
                main.addServlet(HttpServletDispatcher.class, "/api/*");

Also, it might be nice to see if we can get it working with Jitpack.

I didn't know that there is this service (jitpack) and there is https://jitpack.io/#resteasy/resteasy-guice package and it works for me.

repositories {
    mavenCentral()
    maven { url 'https://jitpack.io' }
}
dependencies {
    implementation group: 'dev.resteasy.guice', name: 'resteasy-guice', version: '1.0.0.Alpha1'
}

I will be happy help.

@iain-davis
Copy link
Contributor

Ah interesting! I didn't think to try that as a group. That worked for me, thank you! :)

@asoldano
Copy link
Member

@Ryszard-Trojnacki , I'll let @jamezp comment here regarding pushing artifacts for this project in the maven repo.
I'd like to clarify though that the "dev" in dev.resteasy.* package has nothing to do with the expected stability/maturity level of the software, while it's really connected with the RESTEasy domain name (https://resteasy.dev/).

@jamezp
Copy link
Contributor

jamezp commented Oct 10, 2024

I apologize, I must have missed this question for some reason.

As @asoldano said, the "dev" part of the package name is stable and it's already been deployed to Maven Central https://repo1.maven.org/maven2/dev/resteasy/guice/resteasy-guice/. The dev.resteasy.guice is the new package name.

There will be migration steps in order to use this, and renaming the packages is one of them. I've filed #16 to update to README to reflect this.

@Ryszard-Trojnacki
Copy link
Author

Works for me (even better with dev package). Thank you.

@jamezp
Copy link
Contributor

jamezp commented Oct 10, 2024

No problem @Ryszard-Trojnacki. Once there is some usage and everyone seems satisfied, I'm happy to do a 1.0.0.Final release as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants