Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate NearClipRange from VisualBounds2d #8415

Closed
grtlr opened this issue Dec 11, 2024 · 0 comments · Fixed by #8433
Closed

Separate NearClipRange from VisualBounds2d #8415

grtlr opened this issue Dec 11, 2024 · 0 comments · Fixed by #8433
Labels
🟦 blueprint The data that defines our UI 🪳 bug Something isn't working ui concerns graphical user interface
Milestone
0.21 - Graph View...

Comments

@grtlr
Copy link
Contributor

grtlr commented Dec 11, 2024

Recent changes have added a new NearClipRange component to the VisualBounds2d archetype.

This shows up even in the graph view's UI, where near clipping does not make any sense (it's based on egui).

Image

We should probably move this out to a different archetype (something like Camera maybe?)
@grtlr grtlr added 👀 needs triage This issue needs to be triaged by the Rerun team 🪳 bug Something isn't working labels Dec 11, 2024
@grtlr grtlr added ui concerns graphical user interface 🟦 blueprint The data that defines our UI and removed 👀 needs triage This issue needs to be triaged by the Rerun team labels Dec 11, 2024
@grtlr grtlr mentioned this issue Dec 12, 2024
Merged
@Wumpf Wumpf closed this as completed in 0c13f96 Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🟦 blueprint The data that defines our UI 🪳 bug Something isn't working ui concerns graphical user interface
Projects
None yet
Milestone
0.21 - Graph View, Grid, Undo, Breadc...
Development

Successfully merging a pull request may close this issue.

Factor out NearClipPlane from VisualBounds2D rerun-io/rerun
1 participant
@grtlr