Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time panel does not show density when only timeless data is present #1766

Closed
jleibs opened this issue Apr 4, 2023 · 0 comments · Fixed by #5535
Closed

Time panel does not show density when only timeless data is present #1766

jleibs opened this issue Apr 4, 2023 · 0 comments · Fixed by #5535
Assignees
Labels
🪳 bug Something isn't working ui concerns graphical user interface

Comments

@jleibs
Copy link
Member

jleibs commented Apr 4, 2023

We resolved:

By ensuring the log_time timeline is always created:

However, the time panel still does not behave correctly. The TimeAxis code path makes a couple of assertions that we must have a non-empty set (

assert!(!times.is_empty());
), so initializing that with a default empty set as done in #1763 does not seem to be the correct solution.

The timeless data is being added separately to the density graph (

add_data_point(TimeRange::point(TimeInt::BEGINNING), num_timeless_messages);
) , but it seems something is still messed up in how the range is determined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working ui concerns graphical user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants