Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PlantUML image unencrypted http request makes website "insecure" #1256

Closed
UnlimitedCookies opened this issue Nov 24, 2019 · 2 comments
Closed
Assignees

Comments

@UnlimitedCookies
Copy link

Describe the bug
PlantUML requests the image via unencrypted HTTP and therefore shows a warning message to the user that the site is insecure.

This is requested:

<img src="http://www.plantuml.com/plantuml/svg/U9nLZy4AWp0CXkzvYi3Ele18iKw4NJV6pg7c8DRMfN7Flpg5QGu9uV_oywTEIgBBv67ESt33J47ncLW0rew5GLjY6rzHHY2dmuUKqUAbwvfS07P7Ra5P0dbqvFs9R4d61_afXfrkIgmgTC8PkFDxuQHepFyckpPORBQxVlt1FVHye0wBtPpNo6lQm6SHQWvz_l8BXQPBk000" alt="uml diagram" class="uml-diagram">

To Reproduce
Steps to reproduce the behavior:
Go to: https://docs.requarks.io/releases
See read warning message.
Expected behavior
Shiny encrypted picture from PlantUML

@UnlimitedCookies
Copy link
Author

This might have been solved by #1223 but the wiki.js docs website still uses an HTTP image on its release site - So there's still an issue apparently.

@NGPixel
Copy link
Member

NGPixel commented Nov 24, 2019

The fix only affects new installations. Existing installations must be fixed via the DB or wait the next release which will allow to save the rendering configuration from the admin area.

The releases page on the wiki.js docs website has been fixed.

@NGPixel NGPixel closed this as completed Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants