Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filesystem abstraction for all file related services #228

Closed
5 tasks
akondas opened this issue Jul 20, 2020 · 5 comments
Closed
5 tasks

Filesystem abstraction for all file related services #228

akondas opened this issue Jul 20, 2020 · 5 comments
Labels
enhancement New feature or request

Comments

@akondas
Copy link
Member

akondas commented Jul 20, 2020

This is the summary thread for replacing the current implementation with Filesystem. It all started in #209 (thanks to @jonnyynnoj). Partly for the proxy, work has already been done (details in #221). Things to do:

  • add Filesystem abstration to PackageManager
  • remove Storage interface
  • add Filesystem abstraction to security scanner logic
  • remeber to use streams instead of strings
  • create example configuration for S3 and other popular storage options
@akondas akondas added the enhancement New feature or request label Jul 20, 2020
@pedro-stanaka
Copy link
Contributor

Hi @akondas I would be interested in developing this, is there a way to break down the work here? Seems like a lot of changes for one single MR.

I still didn't dive deep into the code, but wouldn't it be okay for a first iteration to keep the Storage contract and implement the features regarding Filesystem abstraction "under the hood" (e.g. by creating a new implementation of type S3 for Storage).

Please let me know how I can help. I want to deploy this to a Kubernetes cluster and would love to have the storage totally separate from the instance running the application and I would also like to avoid shared volumes.

@akondas
Copy link
Member Author

akondas commented Nov 7, 2020

Hi @pedro-stanaka, you can start with PackageManager and replace Filesystem, AtomicFile and other file related things.
Initially, we started by dividing the storage into a private part and a proxy, but since it can be easily done with directories (this is what it is done now), I would see that there is one filesystem for everything with an appropriate adapter (for example s3).

@pedro-stanaka
Copy link
Contributor

I believe this is now closed, right?

@akondas
Copy link
Member Author

akondas commented Jan 25, 2021

Yes, will be preparing a release, we only need to add examples to the documentation.

@akondas akondas closed this as completed Jan 25, 2021
@akondas
Copy link
Member Author

akondas commented Jan 25, 2021

Thanks for your help 🍻

@akondas akondas reopened this Jan 25, 2021
@akondas akondas closed this as completed Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants