Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(redact): multi-line redactors strip empty lines #1742

Merged

Conversation

emosbaugh
Copy link
Member

Description, Motivation and Context

Multi-line redactors strip empty lines since an empty byte slice == nil

Checklist

  • New and existing tests pass locally with introduced changes.
  • Tests for the changes have been added (for bug fixes / features)
  • The commit message(s) are informative and highlight any breaking changes
  • Any documentation required has been added/updated. For changes to https://troubleshoot.sh/ create a PR here

Does this PR introduce a breaking change?

  • Yes
  • No

@emosbaugh emosbaugh added type::bug Something isn't working bug::normal labels Feb 20, 2025
@emosbaugh emosbaugh requested a review from a team as a code owner February 20, 2025 03:12
@emosbaugh emosbaugh requested a review from laverya February 20, 2025 22:52
@emosbaugh emosbaugh enabled auto-merge (squash) February 20, 2025 22:54
@emosbaugh emosbaugh merged commit b80f38a into main Feb 21, 2025
22 checks passed
@emosbaugh emosbaugh deleted the emosbaugh/20250219/multi-line-redactor-strips-empty-lines branch February 21, 2025 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug::normal type::bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants