Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(preflights): support for builtin kernel modules #1737

Merged
merged 2 commits into from
Feb 17, 2025

Conversation

emosbaugh
Copy link
Member

@emosbaugh emosbaugh commented Feb 17, 2025

Description, Motivation and Context

kernelModule host collector does not take into account the modules.builtin file.

Collector and analyzer fail on some hosts with modules built in.

[   33.194758] cloud-init[974]: ✗  4 host preflights failed
[   33.195554] cloud-init[974]:  •  The 'overlay' kernel module is not loaded or loadable
[   33.196514] cloud-init[974]:  •  The 'ip_tables' kernel module is not loaded or loadable
[   33.196950] cloud-init[974]:  •  The 'br_netfilter' kernel module is not loaded or loadable
[   33.197368] cloud-init[974]:  •  The 'nf_conntrack' kernel module is not loaded or loadable
[   33.197597] cloud-init[974]: Please address these issues and try again.

Checklist

  • New and existing tests pass locally with introduced changes.
  • Tests for the changes have been added (for bug fixes / features)
  • The commit message(s) are informative and highlight any breaking changes
  • Any documentation required has been added/updated. For changes to https://troubleshoot.sh/ create a PR here

Does this PR introduce a breaking change?

  • Yes
  • No

@emosbaugh emosbaugh added type::bug Something isn't working bug::normal labels Feb 17, 2025
@emosbaugh emosbaugh marked this pull request as ready for review February 17, 2025 22:28
@emosbaugh emosbaugh requested a review from a team as a code owner February 17, 2025 22:28
@emosbaugh emosbaugh closed this Feb 17, 2025
@emosbaugh emosbaugh reopened this Feb 17, 2025
@emosbaugh emosbaugh requested review from laverya and squizzi February 17, 2025 22:52
@emosbaugh emosbaugh merged commit 923293e into main Feb 17, 2025
40 of 62 checks passed
@emosbaugh emosbaugh deleted the emosbaugh/20250217/builtin-kernel-modules branch February 17, 2025 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug::normal type::bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants