Skip to content
This repository has been archived by the owner on Mar 24, 2023. It is now read-only.

Ship should always store a debug log #400

Closed
dexhorthy opened this issue Aug 20, 2018 · 4 comments · Fixed by #415
Closed

Ship should always store a debug log #400

dexhorthy opened this issue Aug 20, 2018 · 4 comments · Fixed by #415
Assignees
Labels
type::feature New feature or request

Comments

@dexhorthy
Copy link
Member

Expected behavior

When ship exits with an error, it should leave a ship-debug.log file in .ship, which can be included in support inquiries.

Actual behavior

When ship fails due to an error, the user is instructed to re-run ship with --log-level debug, and use that output for support inquiries.

Information

  • Ship version: 4931a46
  • Docker version: n/a
  • Command line run: ship init github.com/helm/charts/stable/nginxxxxx

Steps to reproduce the behavior

  1. Run ship init above
  2. see it fail
  3. re-run with --log-level=debug is required to get useful debugging logs.
@dexhorthy
Copy link
Member Author

@marccampbell assigning to you to review, feel free to remove yourself and the needs/review label if you're 👍 on this

@dexhorthy dexhorthy self-assigned this Aug 20, 2018
@marccampbell
Copy link
Member

@dexhorthy is the proposal then to create a debug.log at start, and defer deletion of that file until the application exits successfully? This would cause a successful execution to not leave the file, but a failed one to leave it?

@dexhorthy
Copy link
Member Author

@marccampbell something like that, I haven't 100% settled on the implementation, but my feeling is only to leave that file if there was an issue

@marccampbell
Copy link
Member

@dexhorthy 👍 from me on this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type::feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants