Skip to content
This repository has been archived by the owner on Mar 24, 2023. It is now read-only.

ship init command should work for plain kubernetes yaml also #268

Closed
marccampbell opened this issue Aug 8, 2018 · 2 comments · Fixed by #399
Closed

ship init command should work for plain kubernetes yaml also #268

marccampbell opened this issue Aug 8, 2018 · 2 comments · Fixed by #399
Assignees

Comments

@marccampbell
Copy link
Member

When running ship init pointing to an upstream repo that only contains kubernetes yaml (not helm), a default lifecycle should be applied.

@marccampbell marccampbell added the needs-design This needs an implementation design label Aug 8, 2018
@marccampbell
Copy link
Member Author

marccampbell commented Aug 8, 2018

To support this:

  • ship should have a flag to specify the upstream resource type (helm, k8s, ...)

  • ship could try to determine the resource type automatically

  • a default lifecycle for k8s applications, different from the default lifecycle for Helm applications

  • ship should have progress messages printed that communicates this information to the user, i.e.

ship.yaml not found ... determining application type [application-type] ...
Generating default ship.yaml for [application-type] application ...

where [application-type] is the resource type either provided by the flag or determined automatically (helm, k8s, etc.)

@kevherro kevherro assigned kevherro and unassigned kevherro Aug 9, 2018
@dexhorthy
Copy link
Member

I'm going to take a stab at a POC for this

@dexhorthy dexhorthy self-assigned this Aug 17, 2018
@dexhorthy dexhorthy added size/m and removed needs-design This needs an implementation design labels Aug 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants