Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect syntax highlighting for scene expression "X" #182

Closed
Booplicate opened this issue Aug 22, 2022 · 3 comments
Closed

Incorrect syntax highlighting for scene expression "X" #182

Booplicate opened this issue Aug 22, 2022 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers pre-release topic:syntax
Milestone

Comments

@Booplicate
Copy link
Contributor

Extension version

2.1.1

Issue description

scene expression with a string is missing syntax highlighting for strings.

Scope inspector screenshots

Capture

Code

scene expression "/path/here.png"
@Booplicate
Copy link
Contributor Author

Booplicate commented Aug 22, 2022

Just FYI

show expression "/path/here.png"

works fine.

@duckdoom4
Copy link
Collaborator

Thanks for the bug report. I'll look at it when I find the time. Have been extremely busy lately.

Tho feel free to have a look and create a merge request. You could compare the two in this file here and see if you can spot the issue.

(It might also be as simple as swapping the include order of some patterns)

Any help would be greatly appreciated :)

@duckdoom4 duckdoom4 added bug Something isn't working good first issue Good for newcomers pre-release labels Aug 23, 2022
@duckdoom4 duckdoom4 added this to the 2.2.0 milestone Aug 23, 2022
@Booplicate
Copy link
Contributor Author

Oh, I think you're right, it's just missing a pattern, easy to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers pre-release topic:syntax
Projects
None yet
Development

No branches or pull requests

2 participants