Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade got to v11 #6356

Closed
rarkins opened this issue May 29, 2020 · 8 comments · Fixed by #6725
Closed

Upgrade got to v11 #6356

rarkins opened this issue May 29, 2020 · 8 comments · Fixed by #6725
Assignees
@viceice
Labels
priority-2-high Bugs impacting wide number of users or very important features type:refactor Refactoring or improving of existing code

Comments

@rarkins
Copy link
Collaborator

rarkins commented May 29, 2020

No description provided.

@rarkins rarkins added blocked priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:refactor Refactoring or improving of existing code labels May 29, 2020
@viceice viceice mentioned this issue Jun 8, 2020
Closed
@rarkins rarkins added priority-2-high Bugs impacting wide number of users or very important features and removed blocked priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others labels Jun 16, 2020
@rarkins
Copy link
Collaborator Author

rarkins commented Jun 16, 2020

I think this one is unblocked now @viceice @zharinov @szmarczak

@rarkins
Copy link
Collaborator Author

rarkins commented Jun 16, 2020

The challenges of types for this is beyond me. Anyone able to step up?

@rarkins
Copy link
Collaborator Author

rarkins commented Jun 16, 2020

I've found that the changes to get it working in a simple case are small: https://github.com/renovatebot/renovate/compare/refactor/got-11

Need help on the types though.

@viceice
Copy link
Member

viceice commented Jun 16, 2020

I can have a look at it tomorrow

@rjatkins
Copy link

I'm looking forward to seeing this upgrade happen. I'm getting regular errors with Unexpected end of JSON input (maybe 9 times out of 10) from bitbucket-server getPrList while running with latest renovate, on node 12.18.1, and from the looks of the discussion in sindresorhus/got#1062 this upgrade should help somewhat with that. I'll note that the recent refactors around util/http have changed this error away from regularly being an ECONNRESET error, so that seems to be an improvement.

@rarkins
Copy link
Collaborator Author

rarkins commented Jul 4, 2020

@viceice did you hit any obstacles with this?

@viceice
Copy link
Member

viceice commented Jul 4, 2020

Beside some test failures to look at, no.

Had no time to investigate further, maybe on Sunday afternoon. 😔

@viceice viceice mentioned this issue Jul 10, 2020
Merged
2 tasks
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 21.34.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@viceice viceice

Labels
priority-2-high Bugs impacting wide number of users or very important features type:refactor Refactoring or improving of existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(internal): migrate to got v11 renovatebot/renovate
4 participants
@rjatkins @viceice @rarkins @renovate-release