Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress/skip pep621 manager detection of poetry 2.0 projects #33961

Open
rarkins opened this issue Jan 31, 2025 · 0 comments
Open

Suppress/skip pep621 manager detection of poetry 2.0 projects #33961

rarkins opened this issue Jan 31, 2025 · 0 comments
Labels
manager:poetry Poetry package manager priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others

Comments

@rarkins
Copy link
Collaborator

rarkins commented Jan 31, 2025

Describe the proposed change(s).

Currently Poetry 2.0 projects are not recognized by the "poetry" manager, but they are recognized (partially) by the "pep621" manager. We should update the code in https://github.com/renovatebot/renovate/blob/main/lib/modules/manager/pep621/extract.ts so that Poetry 2.0 projects are skipped by the pep621 manager.

This could potentially be done either by looking for signs of poetry in the pyproject.toml, or by looking for a poetry.lock. The pyproject.toml would seem to be more reliable if that is possible.

For now we can assume that "if it's as poetry pyproject.toml, it's not also another pep621 type of project at the same time (e.g. uv)". If someone has a use case where they have both poetry and another pep621 at the same time, we can decide later whether to support that.

@rarkins rarkins added needs-discussion Issue requires a GitHub Discussion first priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others labels Jan 31, 2025
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 31, 2025
@rarkins rarkins added manager:poetry Poetry package manager and removed needs-discussion Issue requires a GitHub Discussion first labels Jan 31, 2025
@rarkins rarkins reopened this Jan 31, 2025
@renovatebot renovatebot deleted a comment from github-actions bot Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
manager:poetry Poetry package manager priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others
Projects
None yet
Development

No branches or pull requests

1 participant