Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(npm): Include @types/react-is in "react monorepo" group #33388

Merged
merged 2 commits into from
Jan 4, 2025

Conversation

stephenwade
Copy link
Contributor

Changes

Include @types/react-is in "react monorepo" group

Context

Discussion: #33387

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

I think this PR will solve the issue, but I don't understand why this code doesn't take care of it:

react: {
description: 'All React packages.',
matchDatasources: ['npm'],
matchPackageNames: ['@types/react**', 'react**'],
},

Or why this package rule isn't defined like:

matchPackageNames: ['@types/react**'],

There is some duplication here of React package names that I don't understand. I just tried to make the minimal change needed to fix the issue in this PR.

@stephenwade stephenwade changed the title Include @types/react-is in "react monorepo" group fix(npm): Include @types/react-is in "react monorepo" group Jan 3, 2025
@rarkins rarkins added this pull request to the merge queue Jan 4, 2025
Merged via the queue into renovatebot:main with commit f2a3ee3 Jan 4, 2025
39 checks passed
@stephenwade stephenwade deleted the patch-1 branch January 4, 2025 07:35
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 39.90.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants