Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hex): fix Elixir's special operator in list #33325

Merged
merged 2 commits into from
Dec 29, 2024

Conversation

sheerlox
Copy link
Contributor

@sheerlox sheerlox commented Dec 29, 2024

Changes

Changes the ~ to the correct value ~> in hex versioning's operators list.

Context

https://hexdocs.pm/elixir/Version.html#module-requirements

Detected while making tests on a branch which contained the changes from #33322:

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test case for this?

@sheerlox sheerlox force-pushed the fix/versioning-hex-operator-bug branch from f8499ce to c248f83 Compare December 29, 2024 11:35
@sheerlox
Copy link
Contributor Author

sheerlox commented Dec 29, 2024

Forced-pushed to add the failing test before the fix, see failed unit test run here.

Rebased against main while at it.

@sheerlox sheerlox requested a review from rarkins December 29, 2024 11:38
@rarkins rarkins added this pull request to the merge queue Dec 29, 2024
Merged via the queue into renovatebot:main with commit 415f5cb Dec 29, 2024
39 checks passed
@sheerlox sheerlox deleted the fix/versioning-hex-operator-bug branch December 29, 2024 17:41
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 39.86.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants