Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(datasource/go): Remove go-source header from gitlab fixtures #32286

Merged
merged 1 commit into from
Nov 1, 2024
Merged

test(datasource/go): Remove go-source header from gitlab fixtures #32286

merged 1 commit into from
Nov 1, 2024

Conversation

malmor
Copy link
Contributor

@malmor malmor commented Nov 1, 2024

Changes

This pull requests removes the go-source header for all GitLab go-get fixtures.

Context

In https://gitlab.com/gitlab-org/gitlab/-/merge_requests/161162 GitLab removed the go-source header from its go-get endpoint responses:

So, the go-source meta tag has been completely removed from the response.

That change has been deployed to gitlab.com and released for self-managed customers since GitLab v17.4.2 (or GitLab v17.5) almost a month ago: https://about.gitlab.com/releases/2024/10/09/patch-release-gitlab-17-4-2-released/

To ensure that the fixtures represent the actual responses, the go-source headers should be removed.

The new behavior can be tested against gitlab.com or any up-to-date self-hosted instance. Here are two examples:

$ curl https://gitlab.com/gitlab-org/gitlab?go-get=1
<html><head><meta name="go-import" content="gitlab.com/gitlab-org/gitlab git https://gitlab.com/gitlab-org/gitlab.git"></head><body>go get gitlab.com/gitlab-org/gitlab</body></html>

$ curl https://git.dev.local/development/go-sdk?go-get=1
<html><head><meta name="go-import" content="git.dev.local/development/go-sdk git https://git.dev.local/development/go-sdk.git"></head><body>go get git.dev.local/development/go-sdk</body></html>

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@malmor
Remove go-source header from gitlab fixtures
1450740 
Signed-off-by: malmor <62105800+malmor@users.noreply.github.com>
@rarkins rarkins added this pull request to the merge queue Nov 1, 2024
Merged via the queue into renovatebot:main with commit 570a727 Nov 1, 2024
39 checks passed
@malmor malmor deleted the test/remove-go-source-from-gitlab-fixtures branch November 1, 2024 21:05
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 38.142.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rarkins rarkins rarkins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@malmor @renovate-release @rarkins