Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CircleCI bump fails tests with Ruby update #3158

Closed
miketheman opened this issue Feb 3, 2019 · 4 comments
Closed

CircleCI bump fails tests with Ruby update #3158

miketheman opened this issue Feb 3, 2019 · 4 comments
Labels
priority-4-low Low priority, unlikely to be done unless it becomes important to more people status:blocked Issue is blocked by another issue or external requirement type:feature Feature (new functionality)

Comments

@miketheman
Copy link

What Renovate type are you using?
Renovate GitHub App

Describe the bug
During a CircleCI version bump of the Ruby runtime in the tests, automated CI tests fail due to a Ruby version mismatch.

Did you see anything helpful in debug logs?
Job Log 43241196

To Reproduce
Steps to reproduce the behavior:

  1. Create repository with a Gemfile with ruby '2.6.0' and a CircleCI .circleci/config.yml with - image: circleci/ruby:2.6.0-node-browsers in the docker section
  2. Configure renovatebot for the repo (default, extends base)
  3. A PR for 'Update circleci/ruby Docker tag to v2.6.1' should be generated, and a failing build should occur:
#!/bin/bash -eo pipefail
bundle check || bundle install
Your Ruby version is 2.6.1, but your Gemfile specified 2.6.0
Your Ruby version is 2.6.1, but your Gemfile specified 2.6.0

Expected behavior
A passing build - perhaps a bump in the Gemfile and Gemfile.lock as part of the same PR

Additional context
Uncertain of where the responsibility lies for a runtime upgrade, as this could be part of the user's responsibility to ensure that each component is in a working state before committing.
It's entirely possible this kind of update should be treated differently, which in that case, there's probably some other messaging to provide around runtime updates.

@rarkins
Copy link
Collaborator

rarkins commented Feb 3, 2019

For Node.js, we currently try to catch all possible locations it's defined and upgrade the in the same PR. I think for Ruby we can do the same, although it's still a work in progress. Gemfile support is still in alpha for example, and we need to add ruby 'x' upgrading to it. Another location is the .ruby-version file (#3090).

@rarkins rarkins added type:feature Feature (new functionality) ready priority-4-low Low priority, unlikely to be done unless it becomes important to more people and removed ready labels Feb 3, 2019
@rarkins
Copy link
Collaborator

rarkins commented Feb 8, 2019

Waiting on #3090

@aaronjensen
Copy link

And .tool-versions #4051

@rarkins rarkins added status:blocked Issue is blocked by another issue or external requirement status:in-progress Someone is working on implementation and removed status:in-progress Someone is working on implementation labels Jan 12, 2021
@HonkingGoose
Copy link
Collaborator

Issue #3090 is resolved now, but we're still waiting on:

@rarkins rarkins closed this as completed May 9, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority-4-low Low priority, unlikely to be done unless it becomes important to more people status:blocked Issue is blocked by another issue or external requirement type:feature Feature (new functionality)
Projects
None yet
Development

No branches or pull requests

4 participants