Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: improve docker build step #30327

Merged
merged 7 commits into from
Jul 23, 2024
Merged

build: improve docker build step #30327

merged 7 commits into from
Jul 23, 2024

Conversation

viceice
Copy link
Member

@viceice viceice commented Jul 23, 2024

Changes

  • use modern syntax
  • use hardlinks to speedup builds
  • download node from github (nodejs.org is flaky)

Docker build step is down to ~1:30min from ~5 min

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Base automatically changed from viceice-patch-1 to main July 23, 2024 11:23
rarkins
rarkins previously approved these changes Jul 23, 2024
@viceice viceice added this pull request to the merge queue Jul 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 23, 2024
@viceice viceice marked this pull request as draft July 23, 2024 11:57
@viceice viceice marked this pull request as ready for review July 23, 2024 12:12
@viceice viceice requested a review from rarkins July 23, 2024 12:12
@viceice viceice enabled auto-merge July 23, 2024 12:25
@viceice viceice added this pull request to the merge queue Jul 23, 2024
Merged via the queue into main with commit db18662 Jul 23, 2024
38 checks passed
@viceice viceice deleted the build/faster-docker-builds branch July 23, 2024 12:32
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 37.440.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants