Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort packageRules in docs, validate with tests #29703

Closed
2 of 3 tasks
HonkingGoose opened this issue Jun 16, 2024 · 0 comments · Fixed by #29798
Closed
2 of 3 tasks

Sort packageRules in docs, validate with tests #29703

HonkingGoose opened this issue Jun 16, 2024 · 0 comments · Fixed by #29798
Assignees
Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:in-progress Someone is working on implementation type:docs Documentation type:refactor Refactoring or improving of existing code

Comments

@HonkingGoose
Copy link
Collaborator

HonkingGoose commented Jun 16, 2024

Describe the proposed change(s).

@rarkins wants to move the packageRules docs to a new page in the docs. Making that move is a big change, with a lot of links to update. To make the move easier, we should refactor and test the current packageRules docs first.

Todos:

  • Write test to check if current packageRules entries are in the right order, test fails, because the list is not properly sorted right now.
  • Move packageRules items into correct order, test passes now.
  • Merge the refactoring PR

Once these todos are done, we can start work on this issue:

@HonkingGoose HonkingGoose added priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:docs Documentation labels Jun 16, 2024
@HonkingGoose HonkingGoose added the type:refactor Refactoring or improving of existing code label Jun 16, 2024
@HonkingGoose HonkingGoose added the status:in-progress Someone is working on implementation label Jun 26, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:in-progress Someone is working on implementation type:docs Documentation type:refactor Refactoring or improving of existing code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants