Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Tidy Scala version normalization code #29642

Merged

Conversation

george-wilson-rea
Copy link
Contributor

Changes

I added this code in extract.ts to detect Scala 3 versions but I did not realise there was already Scala version normalization happening in util.ts, so I've moved the logic there.

Context

I contributed code in #29291 but recently I realised it could be simplified.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

george-wilson-rea and others added 4 commits June 13, 2024 15:19
I added this code in extract.ts to detect Scala 3 versions but I did not realise there was
already Scala version normalization happening in util.ts, so I've moved the logic there.
@rarkins rarkins changed the title chore: Tidy Scala version normalization code refactor: Tidy Scala version normalization code Jun 13, 2024
@rarkins rarkins added this pull request to the merge queue Jun 13, 2024
Merged via the queue into renovatebot:main with commit 7178da3 Jun 13, 2024
37 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.407.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@george-wilson-rea george-wilson-rea deleted the tidy-scala-version-differences branch June 14, 2024 04:14
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants