Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert matchPackage* and excludePackage* rules to use matchGlobOrRegexList #28546

Closed
rarkins opened this issue Apr 20, 2024 · 0 comments
Closed

Convert matchPackage* and excludePackage* rules to use matchGlobOrRegexList #28546

rarkins opened this issue Apr 20, 2024 · 0 comments
Assignees
@rarkins
Labels
core:package-rules Relating to package-rules e.g. matchers priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)

Comments

@rarkins
Copy link
Collaborator

rarkins commented Apr 20, 2024 •
edited
Loading

Describe the proposed change(s).

  • change matchPackageX, matchDepX and associated excludeX matchers to use matchGlobOrRegexList()
  • Later: migrate all other match and exclude values so that we can then (a) remove them, and (b) remove the confusing "or" logic for these special cases (e.g. matchPackageNames or matchPackagePatterns)

Important: document that matchPackageNames is now case-insensitive unless regex is used
@rarkins rarkins added type:feature Feature (new functionality) priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others core:package-rules Relating to package-rules e.g. matchers labels Apr 20, 2024
@rarkins rarkins self-assigned this Apr 20, 2024
@rarkins rarkins mentioned this issue Apr 20, 2024
Merged
6 tasks
@rarkins rarkins changed the title Consolidate matchPackage* and excludePackage* rules using matchGlobOrRegexList Convert matchPackage* and excludePackage* rules to use matchGlobOrRegexList Apr 21, 2024
@rarkins rarkins mentioned this issue Apr 22, 2024
Merged
6 tasks
@HonkingGoose HonkingGoose mentioned this issue Apr 22, 2024
Merged
@rarkins rarkins closed this as not planned Won't fix, can't repro, duplicate, stale Apr 23, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rarkins rarkins

Labels
core:package-rules Relating to package-rules e.g. matchers priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rarkins