-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(templates): populate depTypes for templating #27939
feat(templates): populate depTypes for templating #27939
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
De-duplicate the list
…:juancarlosjr97/renovate into feat/27818-commit-message-prefix-advance
…:juancarlosjr97/renovate into feat/27818-commit-message-prefix-advance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please extract the template helper to a separate PR, so we can merge before the other changes.
renovatebot#27818 Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code LGTM. waiting on @rarkins approval
@viceice did you see the last comment from @rarkins #27939 (comment)? |
@juancarlosjr97 do you have a reproduction repo? I would like to understand why it doesn't already work "as is" without these changes being necessary |
Yes, see this comment @rarkins #27939 (comment) |
@juancarlosjr97 if that's your reproduction repository, please include a description in the readme about expected vs observed behavior so others can understand it |
Hey @rarkins I have updated the README with details of the issue, the identified, and the solution https://github.com/juancarlosjr97/renovate-test-27939/blob/main/README.md :) Let me know if you would like me to add more information, I put information about the reproduction and the found solution. |
🎉 This PR is included in version 37.314.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Changes
Adding a custom helper for handlebars as
includes
that will check if a list of strings will be valid for a template configuration.includes
handlebarsContext
#27818
Documentation (please check one with an [x])
This page already includes the
depTypes
https://docs.renovatebot.com/templates/#other-available-fieldsHow I've tested my work (please select one)
All tests are passing locally with 100% code coverage
This has been tested also on a PR with a public project juancarlosjr97/renovate-test-27818#7
I have verified these changes via: