Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(config): detect missing RENOVATE_CONFIG_FILE #13196

Merged
merged 9 commits into from
Dec 22, 2021
Merged

fix(config): detect missing RENOVATE_CONFIG_FILE #13196

merged 9 commits into from
Dec 22, 2021

Conversation

olegkrivtsov
Copy link
Contributor

Changes:

Renovate silently ignores config if RENOVATE_CONFIG_FILE points to a non-existing file or config.js throws on evaluation #7620

Context:

Closes #7620

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@olegkrivtsov olegkrivtsov mentioned this pull request Dec 19, 2021
Closed
rarkins
rarkins requested changes Dec 20, 2021
View reviewed changes
viceice
viceice reviewed Dec 20, 2021
View reviewed changes
@olegkrivtsov @viceice
Apply suggestions from code review
41e438d 
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@rarkins rarkins marked this pull request as draft December 20, 2021 09:00
viceice
viceice approved these changes Dec 22, 2021
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rarkins I think this is ready,

@rarkins rarkins marked this pull request as ready for review December 22, 2021 07:37
@rarkins rarkins changed the title fix(config): renovate silently ignores config if RENOVATE_CONFIG_FILE points to a non-existing file or config.js throws on evaluation fix(config): detect missing RENOVATE_CONFIG_FILE Dec 22, 2021
@rarkins rarkins merged commit dad3863 into renovatebot:main Dec 22, 2021
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 31.11.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

zanitete pushed a commit to nagra-insight/renovate that referenced this pull request Jan 4, 2022
@olegkrivtsov @viceice @zanitete
fix(config): detect missing RENOVATE_CONFIG_FILE (renovatebot#13196)
f6e1fb0 
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

@rarkins rarkins rarkins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@olegkrivtsov @renovate-release @viceice @rarkins