Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacement PR body text confusion if repo has custom rules #12625

Open
Tracked by #14149
HonkingGoose opened this issue Nov 12, 2021 · 0 comments
Open
Tracked by #14149

Replacement PR body text confusion if repo has custom rules #12625

HonkingGoose opened this issue Nov 12, 2021 · 0 comments
Labels
good first issue Suitable for new contributors priority-4-low Low priority, unlikely to be done unless it becomes important to more people type:refactor Refactoring or improving of existing code

Comments

@HonkingGoose
Copy link
Collaborator

Describe the proposed change(s).

I suggested we add a text to the PR body during the review process 1:

prBodyNotes: [
'This is a special PR that replaces `{{{depNameSanitized}}}` with the community suggested minimal stable replacement version.',
],

But I just realized: a repository admin set their own replacements in the renovate.json file and then the wording is confusing.

Maybe we can change the code like this?

GIVEN Renovate creates a replacement PR
THEN Renovate checks the source of the replacement name and version
IF source of replacement name/version is the community file in the main renovate repo, use current text.
IF source of replacement name/version is from a custom config, use different text.

Or else we could change the wording, so that it doesn't specify the source of the replacement name/version.

Footnotes

  1. https://github.com/renovatebot/renovate/pull/5558

@HonkingGoose HonkingGoose added type:refactor Refactoring or improving of existing code status:requirements Full requirements are not yet known, so implementation should not be started priority-5-triage labels Nov 12, 2021
@HonkingGoose HonkingGoose changed the title Replacement PR body text consfusion if repo has own custom rules Replacement PR body text confusion if repo has custom rules Nov 12, 2021
@HonkingGoose HonkingGoose added priority-4-low Low priority, unlikely to be done unless it becomes important to more people status:ready and removed status:requirements Full requirements are not yet known, so implementation should not be started priority-5-triage labels Nov 14, 2021
@HonkingGoose HonkingGoose added the good first issue Suitable for new contributors label Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Suitable for new contributors priority-4-low Low priority, unlikely to be done unless it becomes important to more people type:refactor Refactoring or improving of existing code
Projects
None yet
Development

No branches or pull requests

2 participants