Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

satisfies with local version identifies incorrectly returning true #764

Open
rarkins opened this issue Feb 14, 2025 · 0 comments
Open

satisfies with local version identifies incorrectly returning true #764

rarkins opened this issue Feb 14, 2025 · 0 comments

Comments

@rarkins
Copy link
Contributor

rarkins commented Feb 14, 2025

Describe the bug

satisfies('1.0.0+2', '==1.0.0+1' currently returns true, but should return false.
satisfies('1.0.0+2', '==1.0.0' currently returns true, but should return false.

Per the pep440 description in https://peps.python.org/pep-0440/#version-matching:

If the specified version identifier is a public version identifier (no local version label), then the local version label of any candidate versions MUST be ignored when matching versions.

If the specified version identifier is a local version identifier, then the local version labels of candidate versions MUST be considered when matching versions, with the public version identifier being matched as described above, and the local version label being checked for equivalence using a strict string equality comparison.

Steps to reproduce

Unit tests

Additional context

renovatebot/renovate#34101 (reply in thread)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant