Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Vite critical CSS resolution when cwd differs from project root #8752

Merged
merged 5 commits into from
Feb 15, 2024
Merged

Fix Vite critical CSS resolution when cwd differs from project root #8752

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
28f6aa7
Fix resolving filepath from root
frandiox Feb 14, 2024
2e2d19e
Merge branch 'dev' into patch-1
markdalgleish Feb 15, 2024
0ef0719
Fix formatting
markdalgleish Feb 15, 2024
328dfaa
Add changeset
markdalgleish Feb 15, 2024
d316123
Merge branch 'dev' into patch-1
markdalgleish Feb 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/remix-dev/vite/styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ const getStylesForFiles = async ({

try {
for (let file of files) {
let normalizedPath = path.resolve(file).replace(/\\/g, "/");
let normalizedPath = path.resolve(rootDirectory, file).replace(/\\/g, "/");
let node = await viteDevServer.moduleGraph.getModuleById(normalizedPath);

// If the module is only present in the client module graph, the module
Expand Down
Loading