Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(remix-server-runtime): use an internal hash for the id in createMemorySessionStorage #7227

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

brophdawg11
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Aug 22, 2023

🦋 Changeset detected

Latest commit: c2fd5cb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/server-runtime Patch
@remix-run/cloudflare Patch
@remix-run/deno Patch
@remix-run/dev Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/architect Patch
@remix-run/express Patch
@remix-run/serve Patch
@remix-run/testing Patch
create-remix Patch
remix Patch
@remix-run/css-bundle Patch
@remix-run/eslint-config Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brophdawg11 brophdawg11 added the feat:sessions Sessions related issues label Aug 22, 2023
@brophdawg11 brophdawg11 self-assigned this Aug 22, 2023
@MichaelDeBoey MichaelDeBoey changed the title Update createMemorySessionStorage to use an internal hash for the id feat(remix-server-runtime): use an internal hash for the id in createMemorySessionStorage Aug 22, 2023
@ryanflorence
Copy link
Member

In the future we plan to rename this to something more obvious it's only recommended for development and initial scaffolding. But we could also probably use the web crypto API for better unique IDs.

@ryanflorence ryanflorence merged commit 68055c4 into dev Aug 22, 2023
9 checks passed
@ryanflorence ryanflorence deleted the brophdawg11/memory-session-id branch August 22, 2023 16:49
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Aug 22, 2023
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-49e8da1-20230823 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 2.0.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting release This issue has been fixed and will be released soon CLA Signed feat:sessions Sessions related issues package:server-runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants