Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(pages/v2): add devServerPort deprecation #7023

Merged
merged 2 commits into from
Aug 8, 2023
Merged

docs(pages/v2): add devServerPort deprecation #7023

merged 2 commits into from
Aug 8, 2023

Conversation

MichaelDeBoey
Copy link
Member

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Aug 1, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: f2ae069

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MichaelDeBoey MichaelDeBoey added docs v2 Issues related to v2 apis labels Aug 1, 2023
brophdawg11
brophdawg11 reviewed Aug 2, 2023
View reviewed changes
docs/pages/v2.md Outdated Show resolved Hide resolved
@MichaelDeBoey MichaelDeBoey force-pushed the add-devServerPort-deprecation-to-v2-docs branch 3 times, most recently from 3e64b90 to c8d2853 Compare August 4, 2023 11:50
@MichaelDeBoey MichaelDeBoey mentioned this pull request Aug 4, 2023
Merged
@MichaelDeBoey MichaelDeBoey force-pushed the add-devServerPort-deprecation-to-v2-docs branch from c8d2853 to 9257ec4 Compare August 5, 2023 15:03
pcattori
pcattori requested changes Aug 8, 2023
View reviewed changes
docs/pages/v2.md Outdated Show resolved Hide resolved
@pcattori pcattori merged commit 2520bc6 into remix-run:main Aug 8, 2023
2 checks passed
@MichaelDeBoey MichaelDeBoey deleted the add-devServerPort-deprecation-to-v2-docs branch August 8, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brophdawg11 brophdawg11 brophdawg11 left review comments

@pcattori pcattori pcattori approved these changes

@machour machour Awaiting requested review from machour

@markdalgleish markdalgleish Awaiting requested review from markdalgleish

@jacob-ebey jacob-ebey Awaiting requested review from jacob-ebey

Assignees

@pcattori pcattori

Labels
CLA Signed docs package:dev v2 Issues related to v2 apis
Projects
No open projects
v2
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichaelDeBoey @pcattori @brophdawg11