Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dev): reuse dev server port for websocket #6476

Merged
merged 8 commits into from
May 25, 2023
Merged

feat(dev): reuse dev server port for websocket #6476

merged 8 commits into from
May 25, 2023

Commits on May 24, 2023

  1. test(hmr): do not assume stderr will be empty

    @pcattori
    pcattori committed May 24, 2023
    Configuration menu
    Copy the full SHA
    61669e5 View commit details
    Browse the repository at this point in the history

  2. fix(dev): stringify existing NODE_ENV for clarity

    @pcattori
    pcattori committed May 24, 2023
    Configuration menu
    Copy the full SHA
    43adafb View commit details
    Browse the repository at this point in the history

  3. feat(dev): use the same port for dev ready messages and websocket

    @pcattori
    pcattori committed May 24, 2023
    Configuration menu
    Copy the full SHA
    c22c934 View commit details
    Browse the repository at this point in the history

  4. refactor(dev): remove vestigial publicDirectory option

    @pcattori
    pcattori committed May 24, 2023
    Configuration menu
    Copy the full SHA
    8ce187c View commit details
    Browse the repository at this point in the history

Commits on May 25, 2023

  1. refactor(dev): rename scheme, host, port options 

    `httpScheme`/`--http-scheme` -> `scheme`/`--scheme`
`httpHost`/`--http-host` -> `host`/`--host`
`httpPort`/`--http-port` -> `port`/`--port`
    @pcattori
    pcattori committed May 25, 2023
    Configuration menu
    Copy the full SHA
    f987ed7 View commit details
    Browse the repository at this point in the history

  2. fix(dev): dev server port priority 

    1. <LiveReload port /> prop
2. `unstable_dev` `--port` flag
3. `unstable_dev.port` config option
4. REMIX_DEV_SERVER_WS_PORT env var (TODO: remove in v2)
5. default: 8002 (TODO: remove in v2)
    @pcattori
    pcattori committed May 25, 2023
    Configuration menu
    Copy the full SHA
    d11a354 View commit details
    Browse the repository at this point in the history

  3. refactor(dev): rename devHttpOrigin -> devOrigin

    @pcattori
    pcattori committed May 25, 2023
    Configuration menu
    Copy the full SHA
    720b9b0 View commit details
    Browse the repository at this point in the history

  4. chore(dev): add changeset for new dev server options

    @pcattori
    pcattori committed May 25, 2023
    Configuration menu
    Copy the full SHA
    94b1dae View commit details
    Browse the repository at this point in the history