feat(server-runtime): v2_headers future flag for inheriting ancestor headers #6431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… route doesn't export `headers` (#5473)
🦋 Changeset detectedLatest commit: bf0bfd6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
brophdawg11
commented
May 19, 2023
| ...(loaderHeaders ? Array.from(loaderHeaders.entries()) : []), | ||
| ...(errorHeaders ? Array.from(errorHeaders.entries()) : []), | ||
| ]); | ||
| } |
There was a problem hiding this comment.
This existing test section is now testing the v2 behavior so removed headers from the child. See below for specific tests that continue to assert the v1 behavior.
brophdawg11
commented
May 19, 2023
| @@ -256,7 +245,6 @@ test.describe("headers export", () => { | |||
| expect(JSON.stringify(Array.from(response.headers.entries()))).toBe( | |||
| JSON.stringify([ | |||
| ["content-type", "text/html"], | |||
| ["x-child-loader", "success"], | |||
There was a problem hiding this comment.
No more headers from children in these tests since we're using the parent headers function
brophdawg11
commented
May 19, 2023
Comment on lines
+43
to
+48
| if (routeModule.headers == null && build.future.v2_headers) { | ||
| let headers = parentHeaders; | ||
| prependCookies(actionHeaders, headers); | ||
| prependCookies(loaderHeaders, headers); | ||
| return headers; | ||
| } |
There was a problem hiding this comment.
There's no need to prependCookies for parenHeaders since that's what we're returning
1 task
brophdawg11
commented
May 22, 2023
jacob-ebey
approved these changes
May 23, 2023
This was referenced Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can be tedious and error-prone to remember to always
export function headers()from every potential leaf route if you care about response headers on document requests. Prior to v1 the logic was to use the deepest renderableheadersfunction that was found but this changed prior to v1 so we're adding it back behind a future flag for v2 to ensure no unintentional breakages in userland.We still only call
headersfor "renderable" routes (those at or above the any active error boundaries), but we'll use the deepest discoveredheadersexport, and not insist on it being a leaf.Continuation of #5473
Closes #3157