Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix splat route index matching #6222

Merged
merged 4 commits into from
Apr 27, 2023

Conversation

brophdawg11
Copy link
Contributor

@brophdawg11 brophdawg11 commented Apr 27, 2023

Reverts PR #6130 (issue #5841)

Before #6130, Remix was creating a route tree as follows:

<Route path="" element={<Root />}>
  { /* routes/ directory */}
</Route>

#6130 removed path="" from the root route:

<Route element={<Root />}>
  { /* routes/ directory */}
</Route>

This allowed a sole routes/$.jsx to match the / route because root is now a true pathless route.

However, it breaks the previous Remix behavior that that root.jsx alone no longer matches /, so while it's not a super-communicated feature, you could no longer create remix apps with simple root.jsx and no routes/ directory.

@changeset-bot
Copy link

changeset-bot bot commented Apr 27, 2023

🦋 Changeset detected

Latest commit: af42cc9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@remix-run/dev Patch
create-remix Patch
@remix-run/css-bundle Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch
@remix-run/vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brophdawg11 brophdawg11 merged commit 06c81e3 into release-next Apr 27, 2023
@brophdawg11 brophdawg11 deleted the brophdawg11/revert-splat branch April 27, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants