Fix useMatches returning different loader data on sub navigation on client side

[wizardlyhel]

Closes: #

• Docs
• Tests

Problem: useMatches returning different route match data on sub navigation. This problem isn't obvious because the last useMatches hook call always returns the correct route's loader data

https://stackblitz.com/edit/remix-run-remix-askr4f?file=app/root.tsx

Navigate between home, test and test 2 page.

1. On full page reload, you will see multiple logs from useMatches of the same route (This is fine and it is due to React re-renders)
2. On sub navigation, you will see multiple logs from useMatches but of different route loader data. It is always the current route and the previous route

Notice that the server side console only logs loader data for the correct route

[changeset-bot]

🦋 Changeset detected

Latest commit: 5be576f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages

Name	Type
remix	Patch
@remix-run/react	Patch
@remix-run/testing	Patch
create-remix	Patch
@remix-run/architect	Patch
@remix-run/cloudflare	Patch
@remix-run/cloudflare-pages	Patch
@remix-run/cloudflare-workers	Patch
@remix-run/css-bundle	Patch
@remix-run/deno	Patch
@remix-run/dev	Patch
@remix-run/eslint-config	Patch
@remix-run/express	Patch
@remix-run/netlify	Patch
@remix-run/node	Patch
@remix-run/serve	Patch
@remix-run/server-runtime	Patch
@remix-run/vercel	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[remix-cla-bot]

Hi @wizardlyhel,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

[remix-cla-bot]

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

[brophdawg11]

@wizardlyhel Thanks for this! Would you mind rebasing onto dev and re-pointing there since this contains a code change (docs-only changes can go straight to main)?

Once updated, I can bring over the new integration tests from #5601 as well and then we can get this merged

[wizardlyhel]

I mess up the rebase recreate the PR #5603 with dev