From d1dc21feeb54995e3d76b51b191075376e84420b Mon Sep 17 00:00:00 2001 From: Jaga Santagostino Date: Sun, 12 Feb 2023 17:10:55 +0100 Subject: [PATCH 1/2] fix suggestion of deprecated shouldReload API --- docs/guides/data-loading.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/guides/data-loading.md b/docs/guides/data-loading.md index 5446b2c9258..c7b39ed1707 100644 --- a/docs/guides/data-loading.md +++ b/docs/guides/data-loading.md @@ -314,7 +314,7 @@ Given the following URLs, the search params would be parsed as follows: ### Data Reloads -When multiple nested routes are rendering and the search params change, all of the routes will be reloaded (instead of just the new or changed routes). This is because search params are a cross-cutting concern and could effect any loader. If you would like to prevent some of your routes from reloading in this scenario, use [shouldReload][should-reload]. +When multiple nested routes are rendering and the search params change, all of the routes will be reloaded (instead of just the new or changed routes). This is because search params are a cross-cutting concern and could effect any loader. If you would like to prevent some of your routes from reloading in this scenario, use [shouldRevalidate][should-revalidate]. ### Search Params in Components @@ -667,7 +667,7 @@ There are three cases where Remix will reload all of your routes: - If the url search params change (any loader could use them) - The user clicks a link to the exact same URL they are already at (this will also replace the current entry in the history stack) -All of these behaviors emulate the browser's default behavior. In these cases, Remix doesn't know enough about your code to optimize the data loading, but you can optimize it yourself with [unstable_shouldReload][should-reload]. +All of these behaviors emulate the browser's default behavior. In these cases, Remix doesn't know enough about your code to optimize the data loading, but you can optimize it yourself with [shouldRevalidate][should-revalidate]. ## Data Libraries @@ -746,7 +746,7 @@ export default function RouteComp() { [prisma]: https://prisma.io [request]: https://developer.mozilla.org/en-US/docs/Web/API/Request [search-params-getall]: https://developer.mozilla.org/en-US/docs/Web/API/URLSearchParams/getAll -[should-reload]: ../route/should-reload +[should-revalidate]: ../route/should-revalidate [url-search-params]: https://developer.mozilla.org/en-US/docs/Web/API/URLSearchParams [url]: https://developer.mozilla.org/en-US/docs/Web/API/URL [use-submit]: ../hooks/use-submit From 9508d89eebe8b6aea69fe5938bd1991a531f8f8f Mon Sep 17 00:00:00 2001 From: Jaga Santagostino Date: Sun, 12 Feb 2023 17:16:21 +0100 Subject: [PATCH 2/2] Update contributors.yml --- contributors.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/contributors.yml b/contributors.yml index 80d588b372d..9041dd9a9af 100644 --- a/contributors.yml +++ b/contributors.yml @@ -242,6 +242,7 @@ - jwnx - kalch - kamtugeza +- kandros - kanermichael - karimsan - kauffmanes