-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(guides/migrating-react-router-app): suggest using Suspense for client only components #5353
docs(guides/migrating-react-router-app): suggest using Suspense for client only components #5353
Conversation
|
Hi @tom-sherman, Welcome, and thank you for contributing to Remix! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run. Thanks! - The Remix team |
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
24838b8
to
467eec1
Compare
467eec1
to
20e4d59
Compare
sergiodxa/remix-utils#159 is now merged! |
99f1a99
to
867ff70
Compare
Co-authored-by: Michaël De Boey <info@michaeldeboey.be>
Hi @tom-sherman! Are you still interested in getting this one merged? If so, please rebase onto latest |
This PR has been automatically closed because we haven't received a response from the original author 🙈. This automation helps keep the issue tracker clean from PRs that are unactionable. Please reach out if you have more information for us! 🙂 |
I have a blog post that touches on why I believe this approach to be a better option, but I think it's more suitable for the docs because it's built into React without a third party library.
I've already raised a PR to remix-utils with the same suggestion in their docs: sergiodxa/remix-utils#159