Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(guides/migrating-react-router-app): suggest using Suspense for client only components #5353

Conversation

tom-sherman
Copy link

I have a blog post that touches on why I believe this approach to be a better option, but I think it's more suitable for the docs because it's built into React without a third party library.

I've already raised a PR to remix-utils with the same suggestion in their docs: sergiodxa/remix-utils#159

@changeset-bot
Copy link

changeset-bot bot commented Feb 2, 2023

⚠️ No Changeset found

Latest commit: c5c8cce

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Feb 2, 2023

Hi @tom-sherman,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Feb 2, 2023

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@tom-sherman tom-sherman force-pushed the suspense-for-client-only-components branch from 24838b8 to 467eec1 Compare February 2, 2023 22:23
@tom-sherman tom-sherman changed the base branch from dev to main February 2, 2023 22:23
@tom-sherman tom-sherman force-pushed the suspense-for-client-only-components branch from 467eec1 to 20e4d59 Compare February 2, 2023 22:24
@tom-sherman
Copy link
Author

sergiodxa/remix-utils#159 is now merged!

@MichaelDeBoey MichaelDeBoey changed the title Suggest using Suspense for client only components docs(guides/migrating-react-router-app): suggest using Suspense for client only components Mar 9, 2023
@MichaelDeBoey MichaelDeBoey force-pushed the suspense-for-client-only-components branch from 99f1a99 to 867ff70 Compare March 9, 2023 01:09
@MichaelDeBoey
Copy link
Member

Hi @tom-sherman!

Are you still interested in getting this one merged?

If so, please rebase onto latest main & resolve conflicts

@MichaelDeBoey MichaelDeBoey added the needs-response We need a response from the original author about this issue/PR label May 2, 2023
@github-actions
Copy link
Contributor

This PR has been automatically closed because we haven't received a response from the original author 🙈. This automation helps keep the issue tracker clean from PRs that are unactionable. Please reach out if you have more information for us! 🙂

@github-actions github-actions bot closed this May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed docs needs-response We need a response from the original author about this issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants