Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(tutorials/jokes): remove ActionData references #5292

Merged
merged 3 commits into from
Jan 28, 2023
Merged

docs(tutorials/jokes): remove ActionData references #5292

merged 3 commits into from
Jan 28, 2023

Conversation

machour
Copy link
Collaborator

@machour machour commented Jan 28, 2023

Closes: #4974

@changeset-bot
Copy link

changeset-bot bot commented Jan 28, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3014ae4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@machour machour added the docs label Jan 28, 2023
@machour machour mentioned this pull request Jan 28, 2023
Closed
@MichaelDeBoey MichaelDeBoey changed the title docs(tutorials/jokes): Remove references to ActionData docs(tutorials/jokes): remove ActionData references Jan 28, 2023
MichaelDeBoey
MichaelDeBoey reviewed Jan 28, 2023
View reviewed changes
Copy link
Member

@MichaelDeBoey MichaelDeBoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these suggestions are more accurate regarding what's happening

docs/tutorials/jokes.md Outdated Show resolved Hide resolved
docs/tutorials/jokes.md Outdated Show resolved Hide resolved
machour and others added 2 commits January 28, 2023 15:23
@machour @MichaelDeBoey
Update docs/tutorials/jokes.md
54f3443 
Co-authored-by: Michaël De Boey <info@michaeldeboey.be>
@machour @MichaelDeBoey
Update docs/tutorials/jokes.md
3014ae4 
Co-authored-by: Michaël De Boey <info@michaeldeboey.be>
@MichaelDeBoey MichaelDeBoey merged commit 06b6e49 into remix-run:main Jan 28, 2023
@machour machour deleted the docs-4974 branch January 28, 2023 15:58
@Varedis Varedis mentioned this pull request Feb 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelDeBoey MichaelDeBoey MichaelDeBoey approved these changes

@mcansh mcansh Awaiting requested review from mcansh

Assignees
No one assigned
Labels
CLA Signed docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Discrepancy in "Mutations" section within App Tutorial
2 participants
@machour @MichaelDeBoey